Skip to Content
This question has been flagged
2 Replies
2715 Views
Avatar
Drew

If I do:

if shipment_obj.move_lines:
    for line in shipment_obj.move_lines: 
        #line.name, line.id etc..

this works no problem, but I shouldn't need the if statement.

If I just do:

    for line in shipment_obj.move_lines: 
       #line.name, line.id etc..

this throws: "TypeError: 'NoneType' object is not iterable"

Just want to know, why this could be?

here for reference: 

shipment_obj = self.pool.get('stock.picking.in').browse(cr, uid, context.get('active_id')) #gives correct shipment obj

trying to access:

 'move_lines': fields.one2many('stock.move', 'picking_id', 'Internal Moves', states={'done': [('readonly', True)], 'cancel': [('readonly', True)]})
Avatar
Discard

Does it really work when using "if", or does it just not throw errors?

Drew
Author

it just throws errors when I don't use the if, its absolutely crazy I know.

Drew
Author

yes when I use the if it works fine

Drew
Author

found the problem. sorry, it is the way I thought the method was called that didn't need to check context and active_id since there would always be a context and active_id, I was wrong.

Avatar
Drew
Author Best Answer

found the problem, context needs to be checked as well as active_id:

 if context is not None and context.get('active_id'):

...it is the way I thought the method was called that didn't need to check context and active_id since there would always be a context and active_id, I was wrong.

Avatar
Discard

The devil was in the details, as usual...

Drew
Author

thanks for your help.

Avatar
Best Answer

If there is no move_lines, it is False, not None.

Try instead:

if shipment_obj.move_lines:
    for line in shipment_obj.move_lines: 
        #line.name, line.id etc..
Avatar
Discard