Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

how to make the "mark done" disappear depending on a condition

Subscribe

Get notified when there's activity on this post

This question has been flagged
5 Replies
2306 Views
Avatar
Aws Hokan

How to change the XML code so that if the signed in user is the assignee user in a certain activity then the "mark done" button should appear to the mentioned user, if the signed in user NOT the assignee user the "mark done" button disappear.
the Activity.xml file that I think should change


0
Avatar
Discard
Aws Hokan
Author

Thanks Jason for response but i tried as you suggest but not working. the code appear as the following :
<button class="o_Activity_toolButton o_Activity_markDoneButton btn btn-link btn-primary pt-0 ps-0"
t-att-title="activityView.markDoneText" t-ref="markDoneButton" t-on-click="activityView.onClickMarkDoneButton" attrs="{'invisible': [('user_id', '!=', uid)]}"
>
<i class="fa fa-check"/> Mark Done
</button>

Aws Hokan
Author

Thank you all for replay. I tried the mentioned solution but still face the same result.
I think that the condition is true but the parameters are false ( the assignee Id and the singed in user id)

Avatar
Jason Vu
Best Answer

Hi,

you can try to add this to your button: 

attrs="{'invisible': [('user_id', '!=', uid)]}"

Hope it helps!

1
Avatar
Discard
Avatar
Osama Hassan
Best Answer

Hello aws hokan, Jason Vu provided sample code for such operation as you didn't provide you code snippet earlier.
Try this

attrs="{'invisible': [('activity_assignee_id', '!=', uid)]}"

upgrade module and clear browser cache as sometimes the cache prevents from changes made in xml/js file.


1
Avatar
Discard
Avatar
Jainesh Shah(Aktiv Software)
Best Answer

Hello Aws Hokan, 


We can achieve this by defining a new Boolean field and we have to compute it's value based on our condition. Now, We'll use this field in the attrs of the "mark done" button. 

Please find code in comment.

Kindly let us know if you face any issue.

Hope it will be helpful to you.

Thanks & Regards,
Email:   odoo@aktivsoftware.com  

Skype: kalpeshmaheshwari

0
Avatar
Discard
Jainesh Shah(Aktiv Software)

Please find code here :-

You can use below code.

# python code:

from odoo import api, fields, models

class MailActivity(models.Model):
_inherit = "mail.activity"

display_mark_done = fields.Boolean(compute="_compute_display_mark_done")
@api.depends("user_id")
def _compute_display_mark_done(self):
for rec in self:
rec.display_mark_done = self.env.user.id == rec.user_id.id

<!--xml code:-->
<!--We'll user 'display_mark_done' field in the attrs of 'mark as done' button like below.-->
<!--please make sure that the priority is set to 100 so that other views can't override our view.-->

<?xml version="1.0" encoding="UTF-8" ?>

<odoo>
<record id="mail_activity_view_form_popup_inherited" model="ir.ui.view">
<field name="name">mail.activity</field>
<field name="model">mail.activity</field>
<field name="priority" eval="100"/>
<field name="inherit_id" ref="mail.mail_activity_view_form_popup"/>
<field name="arch" type="xml">
<xpath expr="//button[@name='action_done']" position="attributes">
<!--other domains are coming from base view and we don't want to override it-->
<attribute name="attrs">
{'invisible': ['|', '|',
('display_mark_done', '=', False),
('activity_category', 'in', ['meeting', 'tax_report']),
('chaining_type', '=', 'trigger')]}
</attribute>
</xpath>
</field>
</record>
</odoo>

Avatar
Nimisha Muralidhar
Best Answer

Hi

You will need to add a condition to the visibility of the button based on the current user's role as the assignee. Use the attrs attribute to define the condition.

Thank You

-1
Avatar
Discard
Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi 

Please try the code given below,

<button name="action_mark_done" string="Mark Done" type="object"
        attrs="{'invisible': [('user_id', '!=', uid)]}"/>

Hope it helps

-1
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now